Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rupato/bot 2098/fix delete and zoom after blockly update #16436

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Rupato/bot 2098/fix delete and zoom after blockly update #16436

merged 8 commits into from
Aug 15, 2024

Conversation

rupato-deriv
Copy link
Contributor

Changed the return type of the method to false after the block is dragged from the flyout. Because other events do not trigger unless this is set to false. The method returns true while the block is being dragged from the flyout.

@boring-cyborg boring-cyborg bot added the Bot label Aug 12, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 13, 2024 4:46am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/16436](https://github.com/binary-com/deriv-app/pull/16436)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-bot-2098fix-delet-71151a.binary.sx?qa_server=red.derivws.com&app_id=38674
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-bot-2098fix-delet-71151a.binary.sx
- **App ID**: `38674`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 37
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-bot-2098fix-delet-71151a.binary.sx/

@coveralls
Copy link

coveralls commented Aug 12, 2024 •
edited
Loading

Coverage Status

coverage: 46.852% (+0.05%) from 46.799%
when pulling 5d13edb on rupato-deriv:Rupato/BOT-2098/Fix-delete-and-zoom-after-blockly-update
into a3da32a on binary-com:master.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited
Loading

⏳ Generating Lighthouse report...

@farabi-deriv farabi-deriv merged commit 7569ae1 into deriv-com:master Aug 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafin-deriv shafin-deriv shafin-deriv approved these changes

@farabi-deriv farabi-deriv farabi-deriv approved these changes

@sandeep-deriv sandeep-deriv sandeep-deriv approved these changes

@vinu-deriv vinu-deriv Awaiting requested review from vinu-deriv

Assignees
No one assigned
Labels
Bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rupato-deriv @coveralls @sandeep-deriv @farabi-deriv @shafin-deriv